Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: Refactor Regions view to componentization #5413

Merged
merged 25 commits into from
Jan 9, 2023
Merged

On-ramp: Refactor Regions view to componentization #5413

merged 25 commits into from
Jan 9, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Dec 20, 2022 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR changes the folder structure for the Regions View in the on-ramp flow, adding tests.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Dec 20, 2022
Base automatically changed from refactor/onramp-get-started to main December 21, 2022 17:10
@wachunei wachunei added the release-5.14.0 Issue or pull request that will be included in release 5.14.0 label Dec 21, 2022
@wachunei wachunei marked this pull request as ready for review December 21, 2022 20:05
@wachunei wachunei requested a review from a team as a code owner December 21, 2022 20:05
@wachunei wachunei marked this pull request as draft December 21, 2022 20:31
@wachunei wachunei marked this pull request as ready for review January 9, 2023 21:19
sethkfman
sethkfman reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 9, 2023
@wachunei wachunei merged commit 19523b8 into main Jan 9, 2023
@wachunei wachunei deleted the refactor/onramp-regions-view branch January 9, 2023 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-5.14.0 Issue or pull request that will be included in release 5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachunei @sethkfman