Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Screenshot deterrent alert #5474

Merged
merged 3 commits into from
Jan 13, 2023
Merged

[IMPROVEMENT] Screenshot deterrent alert #5474

merged 3 commits into from
Jan 13, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Jan 11, 2023 •
edited
Loading

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

Replace the native UI alert from the "Screenshot deterrent" feature.

2. What is the improvement/solution?

Use the new ModalConfirmation from the Design System.

Screenshots/Recordings

RPReplay_Final1673444541.MP4

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/227

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added design-review Any feature that needs feedback from the design team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 11, 2023
@gantunesr gantunesr marked this pull request as ready for review January 11, 2023 13:52
@gantunesr gantunesr requested a review from a team as a code owner January 11, 2023 13:52
@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.14.0 Issue or pull request that will be included in release 5.14.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 11, 2023
@holantonela
Copy link

Legit. Removing design-qa

@holantonela holantonela removed the design-review Any feature that needs feedback from the design team label Jan 13, 2023
@gantunesr gantunesr merged commit 3bf90fc into main Jan 13, 2023
@gantunesr gantunesr deleted the improvement/screenshot-deterrent-alert branch January 13, 2023 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
release-5.14.0 Issue or pull request that will be included in release 5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantunesr @holantonela @blackdevelopa