Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller packages #5532

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Update controller packages #5532

merged 1 commit into from
Jan 18, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 17, 2023 •
edited
Loading

Description

The controller packages have been updated to use the latest versions of each package. The only breaking change that affects mobile was the rename of the provider property of the network controller to providerConfig. Most changes in this commit relate to that change.

Test Cases

  • Overall use of the app (navigate between screens, changed network, added and remove custom networks)
  • Dapp Transactions on MetaMask test dapp
  • Swap Ethereum to DAI on mainnet
  • Send flow transaction of goerli
  • Imported tokens on avalanche
  • Imported nfts on mainnet

Code impact

High - Everything network related

Issue

Updates to latest version of controller packages, which is an ongoing maintenance task.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Gudahtt
Copy link
Member Author

Gudahtt commented Jan 17, 2023

This depends upon #5529

@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 17, 2023
@Gudahtt Gudahtt force-pushed the update-network-controller-to-v2 branch from c0bad47 to 77c139d Compare January 17, 2023 15:58
@Gudahtt
Update controller packages
a1b0744 
The controller packages have been updated to use the latest versions of
each package. The only breaking change that affects mobile was the
rename of the `provider` property of the network controller to
`providerConfig`. Most changes in this commit relate to that change.
@Gudahtt Gudahtt force-pushed the update-network-controller-to-v2 branch from 77c139d to a1b0744 Compare January 17, 2023 16:02
@Gudahtt Gudahtt marked this pull request as ready for review January 17, 2023 18:20
@Gudahtt Gudahtt requested a review from a team as a code owner January 17, 2023 18:20
@Gudahtt
Copy link
Member Author

Gudahtt commented Jan 17, 2023

After this PR has been approved, we can merge it into #5529 and QA them together (as the QA steps are the same)

tommasini
tommasini approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit c57f912 into refactor/5509-refactor-network-controller Jan 18, 2023
@Gudahtt Gudahtt deleted the update-network-controller-to-v2 branch January 18, 2023 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
@sethkfman sethkfman added release-6.0.0 Issue or pull request that will be included in release 6.0.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 30, 2023
@vpintorico vpintorico added release-6.1.0 Issue or pull request that will be included in release 6.1.0 needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed release-6.0.0 Issue or pull request that will be included in release 6.0.0 labels Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-6.1.0 Issue or pull request that will be included in release 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gudahtt @blackdevelopa @tommasini @vpintorico @sethkfman