-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding smoke and regression tags to tests #5546
Conversation
@cortisiko Hey, sorry to bother on this PR, but can I kindly ask you to mark tags as code using I love Metamask it is great product, keep up the good work! |
oh my apologies @smoke, I was unaware that there was a gh profile associated with " @ smoke". I will format the text in the ticket description now. |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…/MetaMask/metamask-mobile into Appium/add-tags-to-feature-files
As an increment to this PR I added the following:
|
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
The time it takes to build and launch tests on bitrise is >90 mins. To prevent tests from timing out on bitrise, we need to add specific tags
@smoke
@regression
on the different E2E tests. We need a better way to specify tags. We should create a constants file for all of our tags. then have a command line flag to run specific tags. For example, if we want to run all tests with the smoke tag we wun do something like this:yarn test:android:qa --tags=smoke
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist