Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Refactor Personal Signature #5551

Merged
merged 6 commits into from
Jan 27, 2023
Merged

[IMPROVEMENT] Refactor Personal Signature #5551

merged 6 commits into from
Jan 27, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Jan 19, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Refactor the personal sign code from JavaScript to Typescript

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses NA

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner January 19, 2023 17:49
@blackdevelopa blackdevelopa self-assigned this Jan 19, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 19, 2023
@blackdevelopa blackdevelopa added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jan 20, 2023
gantunesr
gantunesr requested changes Jan 26, 2023
View reviewed changes
app/components/UI/PersonalSign/PersonalSign.tsx Outdated Show resolved Hide resolved
app/components/UI/PersonalSign/PersonalSign.tsx Outdated Show resolved Hide resolved
@gantunesr
Copy link
Member

Great work! left some feedback

gantunesr
gantunesr approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackdevelopa blackdevelopa added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 27, 2023
@blackdevelopa blackdevelopa merged commit 74ed06d into main Jan 27, 2023
@blackdevelopa blackdevelopa deleted the personal_signature_refactor branch January 27, 2023 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
@cortisiko cortisiko added the release-6.0.0 Issue or pull request that will be included in release 6.0.0 label Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
release-6.0.0 Issue or pull request that will be included in release 6.0.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-confirmations-secure-ux-PR PR from the confirmations team unit test coverage confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blackdevelopa @gantunesr @cortisiko @hilvmason