[FIX] Importing private key via QR code redirects to browser #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommasini
added
the
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
blackdevelopa
approved these changes
Feb 7, 2023
tommasini
added
Mobile QA board
needs-qa
cortisiko
added
QA Passed
cortisiko
approved these changes
Feb 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only tested on android
When it was imported an account (private key) via QR code, closing the "successful screen" is redirecting to the browser tab.
Proposed solution
On dev mode was an error being prompted
The action GO_BACK was not handled by any navigatorand it's fixed, the browser never appeared again on android after importing an account with private key qr codeScreenshots/Recordings
No recording because of privacy content
Test Cases
(Only tested on Android)
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses # https://github.com/MetaMask/mobile-planning/issues/633
Checklist