Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Migrate dapps access into permission controller state #5724

Merged
merged 2 commits into from
Feb 15, 2023
Merged

[FIX] Migrate dapps access into permission controller state #5724

merged 2 commits into from
Feb 15, 2023

Conversation

jpcloureiro
Copy link
Contributor

@jpcloureiro jpcloureiro commented Feb 7, 2023 •
edited
Loading

Description

Create a migration from all allowed hosts & selectedAddress into PermissionController state.

Issue
Progresses: https://github.com/MetaMask/mobile-planning/issues/631

@jpcloureiro jpcloureiro added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.0.0 Issue or pull request that will be included in release 6.0.0 labels Feb 7, 2023
@jpcloureiro jpcloureiro requested a review from a team as a code owner February 7, 2023 21:15
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpcloureiro jpcloureiro changed the title [FIX} Migrate dapps access into permission controller state [FIX] Migrate dapps access into permission controller state Feb 7, 2023
@jpcloureiro jpcloureiro requested a review from Cal-L February 7, 2023 21:17
@jpcloureiro jpcloureiro self-assigned this Feb 7, 2023
@jpcloureiro jpcloureiro removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 8, 2023
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 8, 2023
@sethkfman sethkfman added Mobile QA board needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 14, 2023
@chrisleewilcox chrisleewilcox removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 14, 2023
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Feb 15, 2023
cortisiko
cortisiko approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@Cal-L Cal-L merged commit aeba26c into release/6.0.0 Feb 15, 2023
@Cal-L Cal-L deleted the fix/migrate-existing-dapp-permissions branch February 15, 2023 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@cortisiko cortisiko cortisiko approved these changes

@Cal-L Cal-L Awaiting requested review from Cal-L

Assignees

@jpcloureiro jpcloureiro

Labels
QA Passed A successful QA run through has been done release-6.0.0 Issue or pull request that will be included in release 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jpcloureiro @cortisiko @gantunesr @chrisleewilcox @sethkfman @Cal-L @joaoloureirop