Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Initial Analytics Opt Out #5863

Merged
merged 1 commit into from
Mar 1, 2023
Merged

[FIX] Initial Analytics Opt Out #5863

merged 1 commit into from
Mar 1, 2023
+1 −1

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Mar 1, 2023 •
edited
Loading

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,

1. What is the reason for the change?

There's a bug related to the scenario when a user is onboarding into the app and opts out of MetaMetrics. See first image for reference.

2. What is the improvement/solution?

Add a new conditional to check for the existence of "Deletion Request Date". This should render another content explaining the use of the "Delete Data" feature. See second image for reference.

The "Delete MetaMetrics data" CTA should be disabled.

Screenshots/Recordings

BUG

FIX

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Sorry, something went wrong.

@gantunesr
Add date conditional

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
GPG key ID: DA17C4B29CB32E4B
Verified
Learn about vigilant mode
7ecb9a2
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Mar 1, 2023
@gantunesr gantunesr marked this pull request as ready for review March 1, 2023 12:51
@gantunesr gantunesr requested a review from a team as a code owner March 1, 2023 12:51
tommasini
tommasini approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NicolasMassart
NicolasMassart approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gantunesr gantunesr added release-6.2.0 Issue or pull request that will be included in release 6.2.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 1, 2023
@gantunesr gantunesr merged commit 1474d44 into main Mar 1, 2023
@gantunesr gantunesr deleted the fix/initial-opt-out branch March 1, 2023 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart

@tommasini tommasini

Assignees
No one assigned
Labels
release-6.2.0 Issue or pull request that will be included in release 6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform Mobile Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gantunesr @NicolasMassart @tommasini @gauthierpetetin