Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract test accounts to env vars #5952

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Mar 10, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Extract test accounts SRP and matching addresses to ENV vars that will be provided as secrets in CI.

1. What is the reason for the change?

  • test accounts are automatically drained from any test ETH as SRP is public...
    2. What is the improvement/solution?
  • move infos to env vars
  • setup MM_TEST_ACCOUNT_SRP and MM_TEST_ACCOUNT_ADDRESS secret vars in Bitrise (not env vars).
  • test all tests are passing with the new test account

NOTE: It requires to move tokens and collectibles to this new account

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses MetaMask/mobile-planning#672

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Sorry, something went wrong.

cortisiko and others added 2 commits February 27, 2023 16:51
first pass, some tests are not working because of account change.
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman
Copy link
Contributor

@NicolasMassart I would stub these env values out in the js.env file so people know to add them locally for e2e tests. I would also add a section in the e2e ReadMe.

@NicolasMassart NicolasMassart marked this pull request as ready for review March 15, 2023 15:11
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 15, 2023 15:11
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Mar 15, 2023
@NicolasMassart NicolasMassart merged commit 1484a0e into main Mar 15, 2023
@NicolasMassart NicolasMassart deleted the e2e/create-env-variable-for-test-wallets branch March 15, 2023 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants