Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Prevent account selection reset #5966

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 14, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Include #5911 fix into 6.2.0

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue
#5911

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner March 14, 2023 20:54
@Cal-L Cal-L added the release-6.2.0 Issue or pull request that will be included in release 6.2.0 label Mar 14, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-mobile-client type-bug Something isn't working Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Mar 14, 2023
@Cal-L Cal-L force-pushed the bug/5911-account-sheet-reset branch from ca0eea4 to 31a0d7c Compare March 14, 2023 20:58
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 1393680 into release/6.2.0 Mar 14, 2023
@Cal-L Cal-L deleted the bug/5911-account-sheet-reset branch March 14, 2023 22:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-6.2.0 Issue or pull request that will be included in release 6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants