Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPDATE] pin sonar action to commit #5967

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[UPDATE] pin sonar action to commit #5967

merged 3 commits into from
Mar 15, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Mar 15, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR pins the sonar action to a specific commit per our organizations requirements. This action has no impact on production source code and is only used for static analysis.

Screenshots/Recordings

NA

Issue

NA

Checklist

  • [NA] There is a related GitHub issue
  • [NA] Tests are included if applicable
  • [NA] Any added code is fully documented

@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 15, 2023
@sethkfman sethkfman requested a review from a team as a code owner March 15, 2023 18:58
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Mar 15, 2023
gantunesr
gantunesr approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gudahtt
Gudahtt approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/sonar.yml Outdated Show resolved Hide resolved
@sethkfman sethkfman added release-6.3.0 Issue or pull request that will be included in release 6.3.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 15, 2023
@sethkfman sethkfman merged commit 54a7bc1 into main Mar 15, 2023
@sethkfman sethkfman deleted the update/sonar-action-commit branch March 15, 2023 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@leotm leotm leotm approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-6.3.0 Issue or pull request that will be included in release 6.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethkfman @leotm @Gudahtt @gantunesr