Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] handle rejected os biometric prompt #5971

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Mar 15, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

  • wallet creation fails after a failed biometric attempt

2. What is the improvement/solution?

  • This was not an issue in Auth refactor.
  • The problem here was that the TEMPORARY fix for 6.1 got merged over my code from the authentication refactor which resulted in the password not being stored.
  • simply reverting the handleRejectedOsBiometricPrompt to the logic from Auth refactor solved this issue.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

RPReplay_Final1678915473.MP4

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/708

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@owencraston owencraston requested a review from a team as a code owner March 15, 2023 21:30
@owencraston owencraston changed the base branch from main to release/6.2.0 March 15, 2023 21:30
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston requested a review from sethkfman March 15, 2023 21:35
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owencraston owencraston merged commit 278243b into release/6.2.0 Mar 15, 2023
@owencraston owencraston deleted the fix-handleRejectedOsBiometricPrompt branch March 15, 2023 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants