Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MC 0.5][FEATURE] Account actions on wallet view #6093

Merged
merged 11 commits into from
Apr 27, 2023
Merged

[MC 0.5][FEATURE] Account actions on wallet view #6093

merged 11 commits into from
Apr 27, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 1, 2023 •
edited
Loading

Description
This PR aims to add account actions to the wallet view.
It's possible now with a new design to:

  • View on etherscan the account address
  • Share your account address
  • See your private key

Screenshots/Recordings
Scenario: Should be able to view account on block explorer: https://recordit.co/QoXERxDxIm
Scenario: Should be able to share account address: https://recordit.co/CzLd0kK91a
Scenario: Should be to access private key: https://recordit.co/GoU5YLvOPf

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin changed the title [FEATURE][MC] Account actions on wallet view [MC 0.5][FEATURE] Account actions on wallet view Apr 10, 2023
@tommasini tommasini mentioned this pull request Apr 11, 2023
Merged
3 tasks
@tommasini tommasini added the release-6.5.0 Issue or pull request that will be included in release 6.5.0 label Apr 14, 2023
@tommasini tommasini added release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-client and removed release-6.5.0 Issue or pull request that will be included in release 6.5.0 labels Apr 24, 2023
@tommasini tommasini marked this pull request as ready for review April 24, 2023 17:02
@tommasini tommasini requested a review from a team as a code owner April 24, 2023 17:02
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 24, 2023
Cal-L
Cal-L reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/component-library/components/Icons/Icon/Icon.types.ts Outdated Show resolved Hide resolved
app/component-library/components/Navigation/TabBar/TabBar.tsx Outdated Show resolved Hide resolved
app/components/Views/AccountAction/AccountAction.styles.ts Outdated Show resolved Hide resolved
app/components/Views/AccountAction/AccountAction.styles.ts Outdated Show resolved Hide resolved
app/components/Views/AccountAction/AccountAction.styles.ts Outdated Show resolved Hide resolved
app/components/Views/AccountActions/AccountActions.styles.ts Outdated Show resolved Hide resolved
app/components/Views/AccountActions/AccountActions.styles.ts Outdated Show resolved Hide resolved
app/components/Views/AccountActions/AccountActions.tsx Outdated Show resolved Hide resolved
app/components/Views/AccountActions/AccountActions.tsx Outdated Show resolved Hide resolved
app/components/Views/AccountActions/AccountActions.tsx Outdated Show resolved Hide resolved
@tommasini
Copy link
Contributor Author

Thanks for the review @Cal-L ! All the comments are addressed!

Cal-L
Cal-L approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 26, 2023
@SamuelSalas SamuelSalas added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 27, 2023
@SamuelSalas SamuelSalas merged commit 320a4fb into main Apr 27, 2023
@SamuelSalas SamuelSalas deleted the feature/714-account-actions-sheet branch April 27, 2023 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @Cal-L @gauthierpetetin @SamuelSalas