-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking toAddress to add it to address book #6137
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/components/UI/AddToAddressBookWrapper/AddToAddressBookWrapper.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/AddToAddressBookWrapper/AddToAddressBookWrapper.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left small nit
Address saved not rendered on ERC20 Token TransfersWhenever I am sending an ERC20 token, I can see how clicking toAddress allows me to save the address, but whenever I save it, the Account name is not displayed. It is still displayed the address. Repro
This also happens if I try to Send the token from inside MetaMask instead of the dapp. erc20-token-transfer-address-not-rendered.mp4Add to Address Book does not open with ERC721 SendsWhenever we are trying to send an ERC721 token, when I am on the Confirmation screen, clicking the To Address does not open the Add to Address Book modal. erc721-address-not-open.webmSince there is another issue related to SEnd erc721, it might have some effect on what I am seeing, so maybe after this issue is fixed, this one will be resolved Repro
Add to Address Book with ERC1155 SendsPending to test, as need there is an issue that should be resolved first, otherwise I cannot import any ERC1155 adn test it. |
@seaona : PR is updated with fix, can you plz re-test. The test should fix the issue for all transactions including 1155. |
@jpuri I see the issues fixed! I've checked the ERC721 in Mainnet since I couldn't import tokens manually due to the previous known issue (see ticked blocked by). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #6008
A reusable component is created to wrap child elements, the child elements when clicked will trigger add-to-address-book modal to open.
QA steps:
Add to address book works well at: