Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e appium/713 update account section #6259

Merged
merged 6 commits into from
Apr 25, 2023
Merged

E2e appium/713 update account section #6259

merged 6 commits into from
Apr 25, 2023

Conversation

SamuelSalas
Copy link
Contributor

Description
Detox and Appium test scripts updates to pass the MC changes.

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@SamuelSalas SamuelSalas requested a review from a team as a code owner April 24, 2023 22:36
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@SamuelSalas SamuelSalas self-assigned this Apr 24, 2023
tommasini
tommasini approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's see if it's everything ok with the pipeline

cortisiko
cortisiko approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@SamuelSalas SamuelSalas merged commit fd96eb5 into feature/713-update-account-section Apr 25, 2023
@SamuelSalas SamuelSalas deleted the e2e-appium/713-update-account-section branch April 25, 2023 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@cortisiko cortisiko cortisiko approved these changes

@chrisleewilcox chrisleewilcox Awaiting requested review from chrisleewilcox

@Andepande Andepande Awaiting requested review from Andepande

@NicolasMassart NicolasMassart Awaiting requested review from NicolasMassart

Assignees

@SamuelSalas SamuelSalas

Labels
Appium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelSalas @cortisiko @tommasini