Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix checkbox interaction on Terms of Use #6309

Merged
merged 1 commit into from
May 4, 2023
Merged

[FIX] Fix checkbox interaction on Terms of Use #6309

merged 1 commit into from
May 4, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented May 1, 2023 •
edited
Loading

Description

This PR fixes the interaction when tapping on the checkbox on the Terms of Use page. You should now be able to toggle the agree section using the checkbox.

Screenshots/Recordings

tos.mov

Issue
#6276

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner May 1, 2023 18:58
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-mobile-client type-bug Something isn't working labels May 1, 2023
@Cal-L Cal-L added release-6.6.0 Issue or pull request that will be included in release 6.6.0 needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) in-progress and removed in-progress labels May 1, 2023
sethkfman
sethkfman approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 2, 2023
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 4, 2023
@chrisleewilcox chrisleewilcox merged commit c249e1f into main May 4, 2023
@chrisleewilcox chrisleewilcox deleted the fix/6276-fix-terms-of-use branch May 4, 2023 18:30
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels May 4, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cal-L @sethkfman @chrisleewilcox @gauthierpetetin