[FIX] Appium: Notify appium server test is done #6349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Some tests will fail after test run even if all steps pass which causes issues with results and reports. This was due to our wdio automation not notifying appium that the test has completed, which would cause some callbacks to fail after the test because the callbacks refer to a test sessionID that no longer exist because the sessionID was terminated after the test. You can see the bug by looking at the bitrise logs that is linked to the issue reported.
This change will notify appium that a sessionID has completed and any outstanding callbacks that reference sessionID's that no longer exist will be handled by appium and no failure/error is generated after the test.
Fixes: reporting a failed test after test run even though all test steps passed, reporting the test correctly.
Fixes: callbacks that refer to a terminated/expired test sessionID to be handle without reporting a failure.
Screenshots/Recordings
Bitrise report for all test.
Smoke test on browserstack with CreateNewWallet.feature that was consistently getting the error. All smoke tests pass .
Issue
Progresses #949
Progresses #5845
Checklist