-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ENS name displayed on confirm send page #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
changed the title
Add unit test coverage
Fix ENS name displayed on confirm send page
May 8, 2023
digiwand
previously approved these changes
May 10, 2023
blackdevelopa
previously approved these changes
May 10, 2023
jpuri
added
the
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
label
May 12, 2023
I can see the ENS name on the confirmations page now. Looks good to be merged 💯 @jpuri |
seaona
added
QA Passed
A successful QA run through has been done
release-6.6.0
Issue or pull request that will be included in release 6.6.0
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
May 18, 2023
blackdevelopa
approved these changes
May 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
A successful QA run through has been done
release-6.6.0
Issue or pull request that will be included in release 6.6.0
unit test coverage confirmed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6330
Show ENS name of to address in confirmation page.
QA Steps: