Trigger signing modals from approval requests #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
# Conflicts: # app/components/Nav/Main/RootRPCMethodsUI.js # package.json
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…6-trigger-signing-modals-with-approval-requests
matthewwalsh0
force-pushed
the
chore/786-trigger-signing-modals-with-approval-requests
branch
from
6ed59ac to
bfc0a91
Compare
bergarces
reviewed
May 15, 2023
bergarces
previously approved these changes
May 24, 2023
OGPoyraz
reviewed
May 24, 2023
vinistevam
approved these changes
May 24, 2023
|
Kudos, SonarCloud Quality Gate passed! |
matthewwalsh0
deleted the
chore/786-trigger-signing-modals-with-approval-requests
branch
matthewwalsh0
added
the
release-6.7.0
cortisiko
added
release-7.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trigger the signature request modals using the generic
ApprovalControllerrequests rather than events specific to theSignatureController.Checklist