Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] - Fix input display when editing account name #6413

Merged
merged 3 commits into from
May 16, 2023
Merged

[FIX] - Fix input display when editing account name #6413

merged 3 commits into from
May 16, 2023
+4 −0

Conversation

tommasini
Copy link
Contributor

Description
It was not being possible to edit account name on android

Screenshots/Recordings
https://recordit.co/nG4RiLeTRR

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner May 16, 2023 19:30
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client release-6.6.0 Issue or pull request that will be included in release 6.6.0 labels May 16, 2023
@tommasini tommasini changed the base branch from main to release/6.6.0 May 16, 2023 19:46
Cal-L
Cal-L approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 16, 2023
@Cal-L Cal-L changed the title [FIX] [6.6.0] - Edit account name on android [FIX] - Fix input display when editing account name May 16, 2023
@gauthierpetetin gauthierpetetin added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 16, 2023
@sethkfman sethkfman removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 16, 2023
@tommasini tommasini merged commit 66f7b1d into release/6.6.0 May 16, 2023
@tommasini tommasini deleted the fix/980-edit-account-name-android branch May 16, 2023 23:03
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-6.6.0 Issue or pull request that will be included in release 6.6.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommasini @Cal-L @brianacnguyen @gauthierpetetin @sethkfman