Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [7.1.0] Account incorrectly displayed on transaction review modal #6502

Merged
merged 3 commits into from
Jun 8, 2023
Merged

fix: [7.1.0] Account incorrectly displayed on transaction review modal #6502

merged 3 commits into from
Jun 8, 2023

Conversation

tommasini
Copy link
Contributor

Description
The transaction on send flow was not being reset when we left the send flow.

Proposed Solution
Reset the transaction state when you hit cancel on the send flow.

Screenshots/Recordings
https://recordit.co/3qy43LC5KN

Issue

Progresses ##6434

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client release-7.1.0 Issue or pull request that will be included in release 7.1.0 labels May 31, 2023
@tommasini tommasini requested a review from a team as a code owner May 31, 2023 18:20
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) in-progress labels May 31, 2023
Cal-L
Cal-L approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 2, 2023
@gauthierpetetin gauthierpetetin added ready-for-dev and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 7, 2023
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed ready-for-dev labels Jun 7, 2023
@gauthierpetetin gauthierpetetin added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jun 8, 2023
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Jun 8, 2023
chrisleewilcox
chrisleewilcox approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on....

  • Samsung Galaxy A42 Android 13: PASS
  • iPhone 12 iOS 14.4 simulator: PASS

LGTM

@chrisleewilcox chrisleewilcox merged commit c4bc106 into release/7.1.0 Jun 8, 2023
@chrisleewilcox chrisleewilcox deleted the fix/6434-account-name-incorrect-displayed branch June 8, 2023 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.1.0 Issue or pull request that will be included in release 7.1.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @chrisleewilcox @Cal-L @gauthierpetetin