Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [7.1.0] remove unicode chars from utf8 token symbol #6508

Merged
merged 3 commits into from
Jun 7, 2023
Merged

fix: [7.1.0] remove unicode chars from utf8 token symbol #6508

merged 3 commits into from
Jun 7, 2023

Conversation

tommasini
Copy link
Contributor

Description
On this patch, we address unicode representing null and the end of text from a utf8 representing the token symbol.

Screenshots/Recordings
https://recordit.co/FfehuLYm82

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner May 31, 2023 23:17
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the base branch from main to release/7.1.0 May 31, 2023 23:17
@tommasini tommasini added team-mobile-client needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-7.1.0 Issue or pull request that will be included in release 7.1.0 labels May 31, 2023
Cal-L
Cal-L reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Cal-L
Cal-L approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 1, 2023
jpcloureiro
jpcloureiro reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@jpcloureiro jpcloureiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new issue to track the removal of those TODOs

Should we also remove this patch once the app gets React Native 0.71.6 upgrade?

@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 7, 2023
@chrisleewilcox
Copy link
Contributor

Works from Pixel 5 Android 12 simulator and iOS simulator.

chrisleewilcox
chrisleewilcox approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 1233b48 into release/7.1.0 Jun 7, 2023
@chrisleewilcox chrisleewilcox deleted the fix/6407-token-symbol-issue branch June 7, 2023 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro left review comments

@Cal-L Cal-L Cal-L approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.1.0 Issue or pull request that will be included in release 7.1.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommasini @chrisleewilcox @jpcloureiro @Cal-L @gauthierpetetin