Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): remove labels after issue closed #6534

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

gauthierpetetin
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

An existing automation adds labels on Github issues when they move to a different column on Zenhub.
However these labels are not being removed when the issue is closed.

We need a Github action that removes the following labels from issue once it is closed:

  • product-backlog
  • needs-design
  • design-in-progress
  • ready-for-dev
  • sprint-backlog
  • in-progress
  • blocked
  • needs-dev-review
  • needs-qa
  • issues-found
  • ready-for-release

Screenshots/Recordings

https://recordit.co/PZtLcn6Q5s

Issue

Closes https://github.com/MetaMask/mobile-planning/issues/1010

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gauthierpetetin gauthierpetetin added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Jun 6, 2023
@gauthierpetetin gauthierpetetin self-assigned this Jun 6, 2023
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner June 6, 2023 08:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 8, 2023
@gauthierpetetin gauthierpetetin merged commit 671ece6 into main Jun 9, 2023
@gauthierpetetin gauthierpetetin deleted the feat_remove_labels branch June 9, 2023 06:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
@gauthierpetetin
Copy link
Contributor Author

gauthierpetetin commented Jun 21, 2023

Hi @Gudahtt ,
I just noticed this automation doesn’t work due to this error.

{
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/issues#remove-a-label-from-an-issue"
}

Can we please create a new personal access token called REMOVE_LABEL_TOKEN with “repo” permissions with the metamask-bot account and add it as a secret to the metamask-mobile repo? (I'll then open a new PR to rename GITHUB_TOKEN into REMOVE_LABEL_TOKEN in this file)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants