Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Handles missing WCv2 project ID #6536

Merged
merged 1 commit into from
Jun 6, 2023
Merged

[FIX] Handles missing WCv2 project ID #6536

merged 1 commit into from
Jun 6, 2023

Conversation

andreahaku
Copy link
Contributor

Adds try/catch to catch error in case of missing WalletConnect v2 missing project ID

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@andreahaku andreahaku requested a review from a team as a code owner June 6, 2023 10:16
@andreahaku andreahaku self-assigned this Jun 6, 2023
@andreahaku andreahaku added WalletConnect WalletConnect related issue or bug release-7.0.0 Issue or pull request that will be included in release 7.0.0 needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Code Impact - Low Minor code change that can safely applied to the codebase labels Jun 6, 2023
@andreahaku andreahaku requested a review from sethkfman June 6, 2023 10:18
sethkfman
sethkfman approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku merged commit 8245f5f into release/7.0.0 Jun 6, 2023
@andreahaku andreahaku deleted the fix/handles_missing_wc2_id branch June 6, 2023 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
@andreahaku andreahaku removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@andreahaku andreahaku

Labels
Code Impact - Low Minor code change that can safely applied to the codebase release-7.0.0 Issue or pull request that will be included in release 7.0.0 WalletConnect WalletConnect related issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreahaku @sethkfman