Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Networks text alignement #6549

Merged
merged 7 commits into from
Jun 20, 2023
Merged

fix: Networks text alignement #6549

merged 7 commits into from
Jun 20, 2023
+30 −0

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jun 7, 2023 •
edited
Loading

Description
Text alignment on networks list and network settings.

Screenshots/Recordings
Before:

After:

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Networks screen:
Before:

After:

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client release-7.2.0 Issue or pull request that will be included in release 7.2.0 labels Jun 7, 2023
@tommasini tommasini requested a review from a team as a code owner June 7, 2023 13:45
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the design-review Any feature that needs feedback from the design team label Jun 7, 2023
Cal-L
Cal-L reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

app/component-library/components/Cells/Cell/foundation/CellBase/CellBase.tsx Outdated Show resolved Hide resolved
app/component-library/components/Cells/Cell/foundation/CellBase/CellBase.types.ts Outdated Show resolved Hide resolved
Cal-L
Cal-L previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 8, 2023
@tommasini tommasini removed the design-review Any feature that needs feedback from the design team label Jun 8, 2023
sethkfman
sethkfman approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@tommasini tommasini merged commit ee579b3 into main Jun 20, 2023
@tommasini tommasini deleted the fix/small-ui-networks branch June 20, 2023 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@Cal-L Cal-L Cal-L left review comments

Assignees
No one assigned
Labels
release-7.2.0 Issue or pull request that will be included in release 7.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @sethkfman @Cal-L @gauthierpetetin