Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Translations for permissions management #6554

Merged
merged 1 commit into from
Jun 7, 2023
Merged

feat: Translations for permissions management #6554

merged 1 commit into from
Jun 7, 2023

Conversation

tommasini
Copy link
Contributor

Description
Translations for permissions management.

Screenshots/Recordings

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client release-7.2.0 Issue or pull request that will be included in release 7.2.0 labels Jun 7, 2023
@tommasini tommasini requested a review from a team as a code owner June 7, 2023 19:15
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 7, 2023
sethkfman
sethkfman approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tommasini tommasini merged commit 1309c21 into main Jun 7, 2023
@tommasini tommasini deleted the translations/834-translations branch June 7, 2023 22:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
@gauthierpetetin gauthierpetetin added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-7.2.0 Issue or pull request that will be included in release 7.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommasini @sethkfman @gauthierpetetin