Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Ui for permissions dapp screen #6576

Merged
merged 7 commits into from
Jun 23, 2023
Merged

feat: New Ui for permissions dapp screen #6576

merged 7 commits into from
Jun 23, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jun 9, 2023 •
edited
Loading

Description
Added UI change on the permissions sheet.

Screenshots/Recordings
https://recordit.co/Rst9APMnfD
<img src=""
image

dark mode:
image

image

Test scenario

  • Connect to a dapp
  • open the account sheet
  • Press permission
  • Should have a new UI for the description
    Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner June 9, 2023 11:06
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.2.0 Issue or pull request that will be included in release 7.2.0 team-mobile-client labels Jun 9, 2023
@gauthierpetetin gauthierpetetin mentioned this pull request Jun 13, 2023
Closed
sethkfman
sethkfman previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 14, 2023
@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. and removed Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking No QA Needed Apply this label when your PR does not need any QA effort. labels Jun 19, 2023
@tommasini tommasini added release-7.3.0 Issue or pull request that will be included in release 7.3.0 and removed release-7.2.0 Issue or pull request that will be included in release 7.2.0 labels Jun 22, 2023
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 22, 2023
@SamuelSalas
Merge branch 'main' into ui/834-permissions-managemnet
85e6075
@SamuelSalas
Update the revoke accounts button (#6672)
47236ce 
* Update the revoke accounts button from the browser flow to Disconnect all accounts

* Update Snapshot
@SamuelSalas SamuelSalas added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jun 23, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

NicolasMassart
NicolasMassart approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I checked QA code changes since last approval.

@tommasini tommasini merged commit 0a7830e into main Jun 23, 2023
@tommasini tommasini deleted the ui/834-permissions-managemnet branch June 23, 2023 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@sethkfman sethkfman sethkfman left review comments

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.3.0 Issue or pull request that will be included in release 7.3.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tommasini @NicolasMassart @sethkfman @gauthierpetetin @cortisiko @SamuelSalas