feat: add approval flow success and error pages #6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
force-pushed
the
1027-approval-flow-result-page
branch
2 times, most recently
from
878fcd3 to
247c54c
Compare
app/components/UI/ApprovalFlow/ApprovalFlowResult/ApprovalFlowResult.test.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/ApprovalFlow/ApprovalFlowResult/ApprovalFlowResult.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/ApprovalFlow/ApprovalFlowResult/ApprovalFlowResult.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/ApprovalFlow/ApprovalFlowResult/ApprovalFlowResult.tsx
Outdated
Show resolved
Hide resolved
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
vinistevam
force-pushed
the
1027-approval-flow-result-page
branch
from
eb6c11c to
f79d86d
Compare
matthewwalsh0
approved these changes
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed! |
metamaskbot
added
the
release-7.4.0
|
@vinistevam @matthewwalsh0 can one of you spot check this on release v7.4.0 to ensure it's is working for the release? |
vinistevam
added
the
No QA Needed
|
Thanks @chrisleewilcox going forward we will ensure the labels are included properly before merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
this PR improves the support for approval flows adding the possibility to include a result page for the approval flow (success & error).
@metamask/approval-controllerScreenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Note: the recordings below are for testing the components no change was done on the add & switch approval.
approval-flow-result-error.webm
approval-flow-result-success.webm
result_page_success.webm
result_pages_error.webm
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/1027
Pipeline E2E
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db808fc0-22f9-4007-8b42-7e62004c24ac
Checklist