Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: onPress prop added to SelectItem component #6741

Merged
merged 2 commits into from
Jul 5, 2023
Merged

fix: onPress prop added to SelectItem component #6741

merged 2 commits into from
Jul 5, 2023

Conversation

tommasini
Copy link
Contributor

Description
The SelectItem component didn't have the onPress property.

Added the onPress property to the TouchableOpacity component of SelectItem component

Screenshots/Recordings
https://recordit.co/hzOkc1TxGL

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from brianacnguyen July 5, 2023 13:07
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 5, 2023
deeeed
deeeed approved these changes Jul 5, 2023
View reviewed changes
Copy link

@deeeed deeeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abretonc7s
abretonc7s previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpcloureiro
jpcloureiro previously approved these changes Jul 5, 2023
View reviewed changes
@tommasini tommasini dismissed stale reviews from jpcloureiro and abretonc7s via 9fb66b5 July 5, 2023 16:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tommasini tommasini added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking No QA Needed Apply this label when your PR does not need any QA effort. and removed Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 5, 2023
@tommasini
Copy link
Contributor Author

Merged without running the E2E, to enable teams to switch networks, the E2E will run tonight hopefully and if something is broken, what I don't believe we revert this PR cc: @cortisiko

@tommasini tommasini merged commit 18cb3a3 into main Jul 5, 2023
@tommasini tommasini deleted the fix/select-item-on-press branch July 5, 2023 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
@metamaskbot metamaskbot added the release-7.3.0 Issue or pull request that will be included in release 7.3.0 label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deeeed deeeed deeeed approved these changes

@jpcloureiro jpcloureiro jpcloureiro approved these changes

@brianacnguyen brianacnguyen Awaiting requested review from brianacnguyen

@abretonc7s abretonc7s Awaiting requested review from abretonc7s

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.3.0 Issue or pull request that will be included in release 7.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommasini @jpcloureiro @deeeed @abretonc7s @metamaskbot