Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [7.4.0] - from account address send flow #6841

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix: [7.4.0] - from account address send flow #6841

merged 1 commit into from
Jul 19, 2023

Conversation

tommasini
Copy link
Contributor

Description
From address is not changing when changed on the send flow.
This PR aims to address it by changing the from address on the transaction object.

Screenshots/Recordings

Send flow recording of success and canceling on confirm screen:
http://recordit.co/KZKHskSKQ5

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-7.4.0 Issue or pull request that will be included in release 7.4.0 labels Jul 19, 2023
@tommasini tommasini requested a review from a team as a code owner July 19, 2023 17:13
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the base branch from main to release/7.4.0 July 19, 2023 17:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Cal-L
Cal-L approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-mobile-client and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 19, 2023
chrisleewilcox
chrisleewilcox approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now working for both iOS and Android.

Fixed for both Send flows from action button and asset details.

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 19, 2023
@chrisleewilcox chrisleewilcox merged commit 3cb0b45 into release/7.4.0 Jul 19, 2023
@chrisleewilcox chrisleewilcox deleted the fix/1144-1145-from-account branch July 19, 2023 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.4.0 Issue or pull request that will be included in release 7.4.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @chrisleewilcox @Cal-L @gauthierpetetin