refactor: Consistent provider config naming #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
consistent-provider-config-naming
branch
from
f28432a to
da122aa
Compare
Gudahtt
added
No QA Needed
|
Successful e2e test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88dbefb4-8c40-4170-bf6b-23b76e1df9c5 |
Gudahtt
force-pushed
the
consistent-provider-config-naming
branch
4 times, most recently
from
be52b17 to
ecbfebd
Compare
3 tasks
Gudahtt
force-pushed
the
consistent-provider-config-naming
branch
8 times, most recently
from
a020b22 to
80def06
Compare
The `providerConfig` property of the `NetworkController` used to be named `provider`, which was very easily confused with the `provider` instance (and with various other things that we call "provider"). When that renaming happened, not all local variables and function names were updated accordingly. All references to `providerConfig` now use the term "providerConfig". This change was done to simplify PR #6872, which is part of MetaMask/mobile-planning#798
Gudahtt
force-pushed
the
consistent-provider-config-naming
branch
from
80def06 to
01c162a
Compare
Cal-L
removed
the
needs-dev-review
|
Kudos, SonarCloud Quality Gate passed! |
metamaskbot
added
the
release-7.5.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The
providerConfigproperty of theNetworkControllerused to be namedprovider, which was very easily confused with theproviderinstance (and with various other things that we call "provider"). When that renaming happened, not all local variables and function names were updated accordingly.All references to
providerConfignow use the term "providerConfig".Issue
This change was done to simplify PR #6872, which is part of https://github.com/MetaMask/mobile-planning/issues/798
Checklist