Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore deleted SendEthMultisig.feature file #6956

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Aug 2, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add the appropiate QA label when dev review is completed
    • needs-qa: PR requires manual QA.
    • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
    • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
  6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

PR #6934 converts wdio test to the Detox format and deletes original wdio test. Current PR is restoring original file by the mobile team request.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Deleted feature can be used for manual testing and other things.

Checklist

@sleepytanya sleepytanya added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 2, 2023
@sleepytanya sleepytanya requested a review from a team as a code owner August 2, 2023 16:48
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya self-assigned this Aug 2, 2023
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 2, 2023
@sleepytanya sleepytanya added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) E2E and removed QA in Progress QA has started on the feature. labels Aug 2, 2023
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chrisleewilcox chrisleewilcox merged commit 9c35255 into main Aug 2, 2023
@chrisleewilcox chrisleewilcox deleted the restore-send-eth-multisig-feature branch August 2, 2023 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E QA Passed A successful QA run through has been done release-7.6.0 Issue or pull request that will be included in release 7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants