Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translation ens ipfs alert #6966

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: translation ens ipfs alert #6966

merged 2 commits into from
Aug 3, 2023
+3 −1

Conversation

tommasini
Copy link
Contributor

Description
More info here

Screenshots/Recordings
image

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 3, 2023
@tommasini tommasini requested a review from a team as a code owner August 3, 2023 19:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Cal-L
Cal-L approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 3, 2023
@sethkfman sethkfman merged commit 24df75b into main Aug 3, 2023
@sethkfman sethkfman deleted the translation/1162-translation-ens-ifs-alert branch August 3, 2023 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
@tommasini tommasini added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Aug 3, 2023
@gauthierpetetin gauthierpetetin added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Aug 3, 2023
@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-7.6.0 Issue or pull request that will be included in release 7.6.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @Cal-L @gauthierpetetin @sethkfman