-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: swaps on send flow when amount is insufficient #6980
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6980 +/- ##
==========================================
- Coverage 39.63% 39.61% -0.03%
==========================================
Files 1233 1233
Lines 29810 29830 +20
Branches 2840 2840
==========================================
Hits 11816 11816
- Misses 17302 17321 +19
- Partials 692 693 +1 ☔ View full report in Codecov by Sentry. |
Love this! Could the "Swap" tokens follow the same design pattern as the "Buy more" and be a link within the warning instead of new button? |
This might be outside of scope, but it would be nice to add metrics on this so we can measure its impact and effectiveness. It could be triggering a
|
…vigation to the insufficient funds message
@bschorchit addressed, Here it goes the recording: https://recordit.co/4kUMifjSk6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Regression Pipeline running that have 2 swaps test flows https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8b0d7b14-8b16-4df9-a816-c50d08de6bf1 Important to notice that the swaps e2e are 4 test files, 2 of them are on the smoke e2e and 2 of them are on the regression pipeline |
Last recording: https://recordit.co/O7a8J82Xg2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. Scenarios I also considered:
- attempting to send funds on a network that does not support buying. Ensuring the alert which takes you to the buy flow is not displayed
- attempting to send funds on a network that does not support swapping. Ensuring the alert which takes you to the swap flow is not displayed
Description
PROPOSAL:
During the send flow on the amount screen:
UX to improve
After navigating to the swaps
Future development proposal
The transaction object should have a type (swaps, send_flow, dapp) or split the transaction objects, this way we can have more than one transaction in redux state, which could open opportunities to improve the UX, such as this example.
Screenshots/Recordings
Recording on buy: https://recordit.co/NBdij78xev
Recording on swap: https://recordit.co/4kUMifjSk6
E2E test
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55932a50-d34a-4599-9825-cca5aa681230
Issue
fixes #???
Checklist