Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Approval flow fail to redirect ledger transaction model #7007

Conversation

stanleyyconsensys
Copy link
Contributor

@stanleyyconsensys stanleyyconsensys commented Aug 17, 2023

Description

Approval flow fail to redirect ledger transaction model

resolution : add back navigation props when using Approve model

Screenshots/Recordings

image (4)

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner August 17, 2023 09:33
@stanleyyconsensys stanleyyconsensys changed the base branch from main to feat/ledger-integration August 17, 2023 09:33
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@stanleyyconsensys stanleyyconsensys self-assigned this Aug 17, 2023
@stanleyyconsensys stanleyyconsensys added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Ledger Ledger hardware wallet related issue or development team-mobile-client labels Aug 17, 2023
Copy link
Contributor

@dawnseeker8 dawnseeker8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve since it is simple change.

@stanleyyconsensys stanleyyconsensys merged commit d8c6ff7 into feat/ledger-integration Aug 18, 2023
@stanleyyconsensys stanleyyconsensys deleted the fix/approval-flow-fail-redirect-ledger-transaction-model branch August 18, 2023 08:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ledger Ledger hardware wallet related issue or development team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants