Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Approval modal showing after submit a swap #7142

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Sep 5, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add the appropiate QA label when dev review is completed
    • needs-qa: PR requires manual QA.
    • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
    • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
  6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

This PR aims to fix an approval modal showing after the user swipes to Swap.

  • Included missing object setting the origin and deviceConfirmedOn.

Screenshots/Recordings

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/37150f00-1d4a-401e-af02-f189f745c70a

fix_swap.webm

Issue

fixes #7136

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@vinistevam vinistevam added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Sep 5, 2023
@vinistevam vinistevam marked this pull request as ready for review September 5, 2023 16:43
@vinistevam vinistevam requested a review from a team as a code owner September 5, 2023 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam force-pushed the fix/7136-approval-modal-shown-after-swap branch from c07078b to 79aa918 Compare September 5, 2023 16:46
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (87d50ba) 32.75% compared to head (efa29fa) 32.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7142   +/-   ##
=======================================
  Coverage   32.75%   32.75%           
=======================================
  Files        1006     1006           
  Lines       26957    26957           
  Branches     2128     2128           
=======================================
  Hits         8829     8829           
  Misses      17701    17701           
  Partials      427      427           
Files Changed Coverage Δ
app/components/UI/Swaps/QuotesView.js 2.38% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@davibroc davibroc added the QA Passed A successful QA run through has been done label Sep 6, 2023
Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes and the problem is fixed

@vinistevam vinistevam merged commit 9cf645e into main Sep 6, 2023
@vinistevam vinistevam deleted the fix/7136-approval-modal-shown-after-swap branch September 6, 2023 06:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 6, 2023
@vinistevam vinistevam added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Sep 6, 2023
@chrisleewilcox chrisleewilcox removed the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 6, 2023
@chrisleewilcox chrisleewilcox added release-7.8.0 Issue or pull request that will be included in release 7.8.0 and removed release-7.7.0 Issue or pull request that will be included in release 7.7.0 labels Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] After Swipe to Swap action a confirmation modal is shown that should't be there
6 participants