Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translation ipfs banner #7186

Merged
merged 2 commits into from
Sep 12, 2023
Merged

feat: translation ipfs banner #7186

merged 2 commits into from
Sep 12, 2023

Conversation

tommasini
Copy link
Contributor

Description
image

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Sep 8, 2023
@tommasini tommasini requested a review from a team as a code owner September 8, 2023 21:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added in-progress blocked and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) in-progress labels Sep 8, 2023
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed blocked labels Sep 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

NicolasMassart
NicolasMassart approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gauthierpetetin gauthierpetetin added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 11, 2023
@tommasini tommasini added release-7.8.0 Issue or pull request that will be included in release 7.8.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Sep 11, 2023
@gauthierpetetin gauthierpetetin added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Sep 12, 2023
@tommasini tommasini merged commit 1bd2463 into main Sep 12, 2023
@tommasini tommasini deleted the translation/1216-ipfs-gateway branch September 12, 2023 14:51
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. in-progress issues-found and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. in-progress labels Sep 19, 2023
@gauthierpetetin gauthierpetetin added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 27, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-7.8.0 Issue or pull request that will be included in release 7.8.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommasini @NicolasMassart @gauthierpetetin