-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Convert Form stories #7349
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7349 +/- ##
==========================================
+ Coverage 34.59% 34.61% +0.01%
==========================================
Files 1017 1018 +1
Lines 27150 27137 -13
Branches 2211 2210 -1
==========================================
Hits 9393 9393
+ Misses 17268 17255 -13
Partials 489 489
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A couple comments. Also one suggestion to make PRs easier to read I would suggest using screen casts instead of screenshots e.g.
after.mov
app/component-library/components/Form/HelpText/HelpText.constants.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Form/TextField/foundation/Input/Input.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Form/TextFieldSearch/TextFieldSearch.constants.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Form/TextFieldSearch/TextFieldSearch.stories.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextFieldSearch working for me now. Must have been an issue on my side only. LGTM
Kudos, SonarCloud Quality Gate passed! |
Description
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist