Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable Fixtures in E2E some tests tagged "Regression" #7402

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

SamuelSalas
Copy link
Contributor

@SamuelSalas SamuelSalas commented Oct 6, 2023

Description

Now that fixtures have been implemented in mobile, we should utilize them in our E2E tests. In this particular ticket, the goal is to enable fixtures in the following smoke tests:

  • permission-system-delete-wallet.spec.js
  • permission-system-revoke-single-account.spec.js
  • add-custom-rpc.spec.js

Recording

Bitrise run https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/727339f4-5024-403c-82a1-49a0e171b4d5

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…voke-single-account and add-custom-rpc.spec detox regression test
@SamuelSalas SamuelSalas self-assigned this Oct 6, 2023
@SamuelSalas SamuelSalas requested a review from a team as a code owner October 6, 2023 05:31
@SamuelSalas SamuelSalas changed the title Test: Enable Fixtures in E2E some tests tagged "Regression" test: Enable Fixtures in E2E some tests tagged "Regression" Oct 6, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (24b4b7e) 34.61% compared to head (5f34f4a) 34.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7402   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files        1017     1017           
  Lines       27162    27162           
  Branches     2211     2211           
=======================================
  Hits         9402     9402           
  Misses      17273    17273           
  Partials      487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelSalas SamuelSalas merged commit aedfb78 into main Oct 10, 2023
@SamuelSalas SamuelSalas deleted the test/1243-enable-fixtures-regression branch October 10, 2023 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
@metamaskbot metamaskbot added the release-7.10.0 Issue or pull request that will be included in release 7.10.0 label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Regression Testing release-7.10.0 Issue or pull request that will be included in release 7.10.0 tests Test related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants