Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Yarn V1 README instructions #7496

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Oct 13, 2023

Description

Add instructions to ensure the right version is installed. Yarn v4 will not work. Devs should use Yarn V1

@digiwand digiwand requested a review from a team as a code owner October 13, 2023 19:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L previously approved these changes Oct 13, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 13, 2023
@Cal-L Cal-L changed the title [Docs] Update Yarn V1 README instructions docs: Update Yarn V1 README instructions Oct 13, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (23bf3c2) 34.62% compared to head (905a164) 34.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7496   +/-   ##
=======================================
  Coverage   34.62%   34.62%           
=======================================
  Files        1019     1019           
  Lines       27192    27192           
  Branches     2217     2217           
=======================================
  Hits         9414     9414           
  Misses      17287    17287           
  Partials      491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digiwand digiwand added the team-confirmations-secure-ux-PR PR from the confirmations team label Oct 13, 2023
@digiwand digiwand requested a review from Cal-L October 13, 2023 20:08
@digiwand digiwand force-pushed the doc-update-README-yarn-instructions branch from 1407c43 to 1366da7 Compare October 13, 2023 20:17
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@digiwand digiwand merged commit 52d0be7 into main Oct 13, 2023
@digiwand digiwand deleted the doc-update-README-yarn-instructions branch October 13, 2023 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@metamaskbot metamaskbot added the release-7.10.0 Issue or pull request that will be included in release 7.10.0 label Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.10.0 Issue or pull request that will be included in release 7.10.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants