-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [Part 2] - Ongoing Work for legacy <Text> comp replacement. #7571
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7571 +/- ##
=======================================
Coverage 34.85% 34.85%
=======================================
Files 1028 1028
Lines 27424 27424
Branches 2267 2267
=======================================
Hits 9558 9558
Misses 17356 17356
Partials 510 510
☔ View full report in Codecov by Sentry. |
app/components/UI/AssetOverview/ChartNavigationButton/ChartNavigationButton.tsx
Outdated
Show resolved
Hide resolved
… props direct on <Text> elem
app/components/UI/AssetOverview/ChartNavigationButton/ChartNavigationButton.tsx
Outdated
Show resolved
Hide resolved
Screenshots updated after changes as well. |
Kudos, SonarCloud Quality Gate passed! |
Description
This PR replaces old usage of legacy component with the text component that standardizes on typography provided through theme via @metamask/design-tokens library. This will bring uniformity to all text elements on our app.
Manual testing steps
Screenshots/Recordings
Before
After
Related issues
This is part of ongoing tasks related to issue #6887
Pre-merge author checklist
Pre-merge reviewer checklist