Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: transfer DeeplinkManager.js file to TS #7586

Merged
merged 1 commit into from
Oct 25, 2023
Merged

chore: transfer DeeplinkManager.js file to TS #7586

merged 1 commit into from
Oct 25, 2023
+109 −50

Conversation

omridan159
Copy link
Contributor

@omridan159 omridan159 commented Oct 24, 2023 •
edited
Loading

Description

Transfer the DeeplinkManager.js file from JS to TS to have type safety.

Related issues

Fixes: #

Manual testing steps

  1. Test the deep links behavior with the devnext project on a testing device.
  2. Test the deep links behavior with the devreactnative project on a testing device.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@omridan159 omridan159 requested a review from a team as a code owner October 24, 2023 12:33
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.4% 0.4% Coverage
8.8% 8.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

abretonc7s
abretonc7s approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omridan159 omridan159 added the team-sdk SDK team label Oct 25, 2023
@omridan159 omridan159 merged commit cae93c4 into main Oct 25, 2023
45 of 46 checks passed
@omridan159 omridan159 deleted the chore_transfer-DeeplinkManager-file-to-TS branch October 25, 2023 06:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 25, 2023
@omridan159 omridan159 restored the chore_transfer-DeeplinkManager-file-to-TS branch October 25, 2023 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abretonc7s abretonc7s abretonc7s approved these changes

Assignees
No one assigned
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omridan159 @abretonc7s @metamaskbot