-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump browserify-sign to v 4.2.2 #7633
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/205e6a35-5dfe-4f3b-b9ea-3fc4e35b905e |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/282d3d22-25fd-4c64-a29c-1a6b119dfae2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7633 +/- ##
=======================================
Coverage 34.98% 34.99%
=======================================
Files 1030 1030
Lines 27382 27385 +3
Branches 2253 2253
=======================================
+ Hits 9580 9583 +3
Misses 17292 17292
Partials 510 510
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
More context on this thread |
@SocketSecurity ignore-all |
Description
Minor version used on the app was 4.0.0
New version 4.2.2
No major upgrades
https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Sanity test:
https://recordit.co/yLlLmu5s2f
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist