-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add account type tag label #7641
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7641 +/- ##
==========================================
+ Coverage 34.99% 35.08% +0.08%
==========================================
Files 1034 1034
Lines 27537 27530 -7
Branches 2298 2301 +3
==========================================
+ Hits 9637 9658 +21
+ Misses 17387 17355 -32
- Partials 513 517 +4
☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d5dedcb-3171-43df-aef9-9f82cc30107c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I only added a few suggestions, but nothing that should prevent this to go through.
app/components/Views/AccountConnect/AccountConnectSingle/AccountConnectSingle.tsx
Show resolved
Hide resolved
app/component-library/components/Pickers/PickerAccount/PickerAccount.styles.ts
Outdated
Show resolved
Hide resolved
app/components/Views/SendFlow/AddressElement/AddressElement.styles.ts
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Description
Enable account type tag label
QR Hardware
Imported
getKeyringByAddress
to get keyring by address for reuse logic purposeisHardwareAccount
to determined address is hardware account or notgetLabelTextByAddress
to return label transaction key base on account typeRelated issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist