-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: blockaid banner should not be visible if option has not been enabled in settings #7798
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7798 +/- ##
=======================================
Coverage 35.08% 35.08%
=======================================
Files 1039 1039
Lines 27628 27638 +10
Branches 2336 2337 +1
=======================================
+ Hits 9693 9697 +4
- Misses 17412 17418 +6
Partials 523 523 ☔ View full report in Codecov by Sentry. |
…obile into blockaid_setting_fix
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c441b88f-e0f9-4681-bf01-21ffe6fd5192 |
Kudos, SonarCloud Quality Gate passed! |
Description
blockaid banner should not be visible if option has not been enabled in settings
Related issues
Fixes: #7780
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist