feat: New mobile Flask Build Type

[owencraston]

Description

This change enables a new build type for MetaMask mobile. This new build is called flask and will be used for the canary distribution of features, namely snaps. These builds will be distributed through the google play store as a new app listing on android, and through tetsflight on iOS. These builds already exist through the work of mobile snaps. This PR pulls in the non snaps related code for creating these builds. The end result is new "flavour" of metamask, that is identical to the main build. Once we merge code fencing into main, we can then start merging snaps code into then flask build without effecting the main build.

• Most of this work was already implemented and reviewed in this PR. We are now updating it and bringing it into main.

Bitrise

• Flask Bitrise build ✅
  • Passed. We expect the deploy android to store to fail since we need Dan Finlay to help us setup the last part of the pipeline. APKS and IPA are present in the artifacts and iOS has been uploaded to testflight.

• QA Bitrise build ✅
  • Passed with no issues
• Release
  • Passed with no issues ✅
• E2E Smoke ✅
  • Passed with no issues.
• E2E regression test ✅
  • Passed with no issues

Testflight

Main build

• I created a test production release to verify that these changes do not effect production releases. You can test this out on Testflight v7.12.1 1213.

RPReplay_Final1700791919.MP4

Flask Build

• version 0.0.4 1212
• This build is available for testing through testflight
• the app is correctly built and everything is working
• the proper code fencing (flask) has been applied

RPReplay_Final1700780718.MP4

Related issues

Progresses: https://github.com/MetaMask/accounts-planning/issues/143

Manual testing steps iOS

1. checkout this PR and run yarn setup
2. run yarn watch:clean
3. open the app in Xcode
4. click the drop down menu with the orange fox (pictured below) and select MetaMask-Flask as your new variant
5. click build (play button)
6. you can also run flask with yarn run start:ios:flask
7. the app should build on the emulator with the purple fox icon and the name MetaMask Flask
8. open the app and create a wallet
9. the app should function normally

Manual testing steps Android

1. checkout this PR and run yarn setup
2. run yarn watch:clean
3. open the app in android studio
4. open the build variants through View/Tool window/Variants

6. In the build variant tab, open the app variants and select flaskDebug

7. now click the green build button
8. you can also run flask with yarn run start:android:flask
9. the app should build on the emulator with the purple fox icon and the name MetaMask Flask
10. open the app and create a wallet
11. the app should function normally

Screenshots/Recordings

Android

iOS

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b58f4f6) 37.44% compared to head (9f8bb52) 37.46%.

Files	Patch %	Lines
app/util/sentry/utils.js	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7837      +/-   ##
==========================================
+ Coverage   37.44%   37.46%   +0.02%     
==========================================
  Files        1052     1052              
  Lines       28192    28202      +10     
  Branches     2517     2517              
==========================================
+ Hits        10556    10566      +10     
  Misses      17037    17037              
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eb8499b8-c6f5-4604-a873-8a273a776b6c
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[wachunei]

From a general point of view, Flask build should point to Dev/Test/Staging or Production services, eg: swaps, ramp?

[gantunesr]

Left some minor comments

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8384a612-ea83-45a2-8f14-44581c9f85ef
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[owencraston]

@wachunei as clarified on slack, we want to have all the ramps environments pointing to the same production end point when flask is released to stores.

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

[socket-security]

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

[owencraston]

yarn run start:ios:flask is working ✅

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

25.5% Coverage
0.0% Duplication

[sethkfman]

LGTM