-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert javascript disabled on the webview #7893
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7893 +/- ##
=======================================
Coverage 37.38% 37.39%
=======================================
Files 1052 1052
Lines 28177 28173 -4
Branches 2517 2517
=======================================
Hits 10534 10534
+ Misses 17044 17040 -4
Partials 599 599 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
This PR reverts this PR
This PR needs to be reverted because when the user is on in app browser and needs to switch network, it will disable the javascript and that will make the dapp be misaligned.
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist