Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert javascript disabled on the webview #7893

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

tommasini
Copy link
Contributor

Description

This PR reverts this PR

This PR needs to be reverted because when the user is on in app browser and needs to switch network, it will disable the javascript and that will make the dapp be misaligned.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner November 21, 2023 12:24
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 21, 2023
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c31cd25) 37.38% compared to head (7d32970) 37.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7893   +/-   ##
=======================================
  Coverage   37.38%   37.39%           
=======================================
  Files        1052     1052           
  Lines       28177    28173    -4     
  Branches     2517     2517           
=======================================
  Hits        10534    10534           
+ Misses      17044    17040    -4     
  Partials      599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tommasini tommasini merged commit b21a4dd into main Nov 21, 2023
33 checks passed
@tommasini tommasini deleted the fix/revert-javascript-disabled-webview branch November 21, 2023 17:04
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 21, 2023
@tommasini tommasini added release-7.12.0 Issue or pull request that will be included in release 7.12.0 and removed release-7.13.0 Issue or pull request that will be included in release 7.13.0 labels Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants