-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Created SelectOption #7969
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7969 +/- ##
==========================================
+ Coverage 39.46% 39.47% +0.01%
==========================================
Files 1227 1231 +4
Lines 29796 29808 +12
Branches 2833 2834 +1
==========================================
+ Hits 11759 11768 +9
- Misses 17345 17348 +3
Partials 692 692 ☔ View full report in Codecov by Sentry. |
…to morph/select-option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left some minor non-blocking comments.
- Checked code
- Checked documentation links, spelling and gramma
- Did not check running in simulator
Make sure you fill out the PR description properly you are missing:
- Manual testing steps
- Link to the related issue
- Checkboxes
PR descriptions greatly help with review and have massive pay offs in future when looking back on work and decisions made in the code base
app/component-library/components/Select/SelectOption/SelectOption.stories.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Select/SelectOption/SelectOption.test.tsx
Show resolved
Hide resolved
app/component-library/components/Select/SelectOption/SelectOption.tsx
Outdated
Show resolved
Hide resolved
…to morph/select-option
…to morph/select-option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have some failing tests but code LGMT. Remember to fill out the PR description so we can understand what this PR contains in future
Co-authored-by: George Marshall <george.marshall@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but you haven't filled out the PR template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fill out PR template otherwise LGTM
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Related issues
Manual testing steps
Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-30.at.16.23.17.mp4
Pre-merge author checklist
Pre-merge reviewer checklist