Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new header to coin gecko endpoint #7984

Closed
wants to merge 3 commits into from
Closed

feat: add new header to coin gecko endpoint #7984

wants to merge 3 commits into from

Conversation

tommasini
Copy link
Contributor

Description

  • Implements new header for the coin gecko fetch exchange rate endpoint on TokensRateController
  • Delete cleaning exchangeRate on every request on TokenRatesController

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

https://recordit.co/bRoTBJjwHs

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini
remove clean exchange rate between requests, re add clean when networ…
aa41e44 
…k change, add new header
@tommasini
cleaning exchange rates between network changes lead to infinite load…
587d455 
…ing it seems due to the 429 error from coin gecko that happens sometimes, it is a rate limit error
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Dec 1, 2023
@tommasini tommasini requested a review from a team as a code owner December 1, 2023 20:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title feature: add new header to coin gecko endpoint feat: add new header to coin gecko endpoint Dec 1, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@metamaskbot metamaskbot added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) in-progress labels Dec 1, 2023
@sethkfman
Copy link
Contributor

sethkfman commented Dec 5, 2023 •
edited
Loading

@tommasini Should this be close in favor of #7991

@tommasini
Copy link
Contributor Author

Yes totally 💯

@tommasini tommasini closed this Dec 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @sethkfman @gauthierpetetin @metamaskbot