chore: split the SDKConnect class into smaller chunks and add unit tests

[omridan159]

Description

Split the SDKConnect class into smaller chunks to make the code more testable and add unit tests.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (635daa3) 37.92% compared to head (ef032ae) 38.81%.

Files	Patch %	Lines
.../core/SDKConnect/ConnectionManagement/reconnect.ts	42.59%	21 Missing and 10 partials ⚠️
.../core/SDKConnect/StateManagement/handleAppState.ts	39.02%	19 Missing and 6 partials ⚠️
...p/core/SDKConnect/InitializationManagement/init.ts	0.00%	12 Missing ⚠️
...e/SDKConnect/InitializationManagement/asyncInit.ts	68.96%	6 Missing and 3 partials ⚠️
app/core/SDKConnect/AndroidSDK/bindAndroidSDK.ts	14.28%	5 Missing and 1 partial ⚠️
...DKConnect/ConnectionManagement/connectToChannel.ts	85.18%	2 Missing and 2 partials ⚠️
...SDKConnect/ConnectionManagement/watchConnection.ts	75.00%	2 Missing and 2 partials ⚠️
app/core/SDKConnect/SDKConnect.ts	87.87%	3 Missing and 1 partial ⚠️
app/core/SDKConnect/SessionManagement/unmount.ts	83.33%	2 Missing and 1 partial ⚠️
...ore/SDKConnect/ConnectionManagement/approveHost.ts	83.33%	1 Missing and 1 partial ⚠️
... and 9 more

Additional details and impacted files

@@                               Coverage Diff                               @@
##           chore_add-unit-tests-to-SDKConnect-handlers    #8028      +/-   ##
===============================================================================
+ Coverage                                        37.92%   38.81%   +0.88%     
===============================================================================
  Files                                             1140     1163      +23     
  Lines                                            29196    29206      +10     
  Branches                                          2746     2747       +1     
===============================================================================
+ Hits                                             11074    11337     +263     
+ Misses                                           17478    17195     -283     
- Partials                                           644      674      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andreahaku]

LGTM

[socket-security]

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue	Package	Version	Note	Source
New author	parse5-htmlparser2-tree-adapter	7.0.0	New Author: feedic Previous Author: inikulin	enzyme@3.9.0, enzyme-adapter-react-16@1.10.0, enzyme-to-json@3.3.5 via package.json

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore parse5-htmlparser2-tree-adapter@7.0.0

The base branch was changed.

[andreahaku]

LGTM

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

73.8% Coverage
0.0% Duplication

[christopherferreira9]

Tiny tiny detail that may have come from a different branch. The console.warn in the video can be ignored.

Screen.Recording.2023-12-12.at.17.05.04.mov

Steps:

1. Connect via QR Code and select "Do not remember me"
2. Refresh dapp
3. A loader is presented even though it can't resume since it did not save the room.

Expected result:
The loader is not presented

Actual result:
You get a loader

[christopherferreira9]

Since the bug reported doesn't break the overall functionality and is of low severity this is going to merged and #8079 was opened.